Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, Anthony Emengo <aemengo(at)pivotal(dot)io>, Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox
Date: 2018-05-15 12:35:25
Message-ID: CA+OCxox9-kRi-5ui9oQ9DHLYOmESbCB1iFpf-jeAUw6+hb=dbQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Tue, May 15, 2018 at 1:24 PM, Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> I suggest check which keyboard you are using, US or UK. If UK, try with US
> keyboard.(might work)
>

How would that make any difference? (and yes, I am using a UK keyboard).

>
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>
> On Tue, May 15, 2018 at 11:35 AM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave
>>
>> On Mon, May 14, 2018 at 6:33 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>>
>>>
>>> On Mon, May 14, 2018 at 2:03 PM, Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Dave
>>>>
>>>> On which database server you are running this test cases, I have tested
>>>> it on PG 9.6
>>>>
>>>
>>> PG 9.4.
>>>
>>
>> I have tested it with PG 9.4 on Mac OSX and Ubuntu 16, working
>> absolutely fine. Can you please provide the *postgresql.conf* is there
>> any parameter changed? OR is there any change in "datatype_test.json"
>> file ?
>>
>>>
>>>
>>>>
>>>> On Mon, May 14, 2018 at 5:45 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>>
>>>>> Hi
>>>>>
>>>>> On Mon, May 14, 2018 at 7:29 AM, Akshay Joshi <
>>>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Anthony
>>>>>>
>>>>>> Thanks for updated patch, it is working fine on my machine. I have
>>>>>> tested it couple of times.
>>>>>>
>>>>>>
>>>>> I've tested it a couple of times and still see the pgDataType failure.
>>>>> I've attached the screenshot; I have to wonder why that test is throwing a
>>>>> syntax error at all as it's only supposed to test that we display different
>>>>> datatypes correctly. Looking further, it seems that it's trying to execute
>>>>> a badly corrupted query. How did it get that way? Do we need to clear the
>>>>> CodeMirror box before trying to replace the query?
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> *Akshay Joshi*
>>>>
>>>> *Sr. Software Architect *
>>>>
>>>>
>>>>
>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>>
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2018-05-15 12:45:54 Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox
Previous Message Dave Page 2018-05-15 12:34:48 Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox