Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Hi

On Tue, May 9, 2017 at 10:28 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
wrote:

> Hi Dave,
>
> Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar'
> related compilation error in Qt4. BUT
>
> Below compilation error is coming because we have not applied the latest
> patch of webkit which was fixed in annulen/webkit repo which was raised at
> below path.
>
> https://github.com/annulen/webkit/issues/519
>
> BrowserWindow.cpp:842:59: error: ‘RequestClose’ is not a member of
> ‘QWebPage’
> webviewPtr->page()->triggerAction(QWebPage::
> RequestClose);
>
> To fix the above compilation error currently we have two solution.
>
> - Apply the given patch in webkit ( qwebpage.cpp & qwebpage.h file ) .
> - Comment the below line temporary for compilation until we get the
> releases from annulen/webkit.
>
> webviewPtr->page()->triggerAction(QWebPage::RequestClose);
>
> Other compilation issues, (Me and Akshay) will fix and commit it but need
> your input on above issue.
>

For various reasons we need to retain compatibility with the previous
versions of qtwebkit. Can we detect at build time what version we have, and
enable/disable that code as appropriate?

>
> Thanks,
> Neel Patel
>
> On Tue, May 9, 2017 at 2:02 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>
> wrote:
>
>> It's running CentOS 7.3, with packages from EPEL:
>>
>> [dpage(at)jenkins ~]$ rpm -qa |grep qt
>> qt5-qtbase-common-5.6.1-10.el7.noarch
>> qt5-qtbase-devel-5.6.1-10.el7.x86_64
>> qt-4.8.5-13.el7.x86_64
>> qt5-qtbase-5.6.1-10.el7.x86_64
>> qt5-qtxmlpatterns-5.6.1-10.el7.x86_64
>> qt5-qtwebchannel-5.6.1-10.el7.x86_64
>> qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64
>> qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64
>> qt-devel-4.8.5-13.el7.x86_64
>> qt-settings-19-23.5.el7.centos.noarch
>> qt5-qtbase-gui-5.6.1-10.el7.x86_64
>> qt5-qtlocation-5.6.1-10.el7.x86_64
>> qt5-qtwebsockets-5.6.1-10.el7.x86_64
>> qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64
>> qtwebkit-2.3.4-6.el7.x86_64
>> qt3-3.3.8b-51.el7.x86_64
>> qt5-qtdeclarative-5.6.1-10.el7.x86_64
>> qt5-rpm-macros-5.6.1-10.el7.noarch
>> qtwebkit-devel-2.3.4-6.el7.x86_64
>> qt-x11-4.8.5-13.el7.x86_64
>> qt5-qtsensors-5.6.1-10.el7.x86_64
>>
>> On Tue, May 9, 2017 at 9:28 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
>> wrote:
>>
>>> Hi Dave,
>>>
>>> Yes, It looks like compilation fails on Qt4. We will fix this issue but
>>> which version of Qt4 we are using in Jenkins ?
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>> On Tue, May 9, 2017 at 1:56 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>
>>> wrote:
>>>
>>>>
>>>>
>>>> On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi <
>>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Tue, May 9, 2017 at 1:42 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>
>>>>> wrote:
>>>>>
>>>>>> This appears to have made Jenkins get all angry and red :-(
>>>>>>
>>>>>> https://jenkins.pgadmin.org/
>>>>>>
>>>>>
>>>>> We(Neel and I) have tested it and working fine.
>>>>>
>>>>
>>>> It clearly doesn't compile on QT4. Please review the Jenkins logs.
>>>>
>>>>
>>>>>
>>>>>>
>>>>>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <
>>>>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>>>>
>>>>>>> Thanks patch applied.
>>>>>>>
>>>>>>> On Mon, May 8, 2017 at 3:21 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>>>
>>>>>>>> Akshay, could you review this please?
>>>>>>>>
>>>>>>>> Thanks.
>>>>>>>>
>>>>>>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel <
>>>>>>>> neel(dot)patel(at)enterprisedb(dot)com> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> Please find attached patch file with the fix of RM #2328 -
>>>>>>>>> [Runtime]: Unable to launch query tool and debugger in new browser tab.
>>>>>>>>>
>>>>>>>>> I have used Qt 5.8 with webkit mentioned in below URL.
>>>>>>>>>
>>>>>>>>> https://github.com/annulen/webkit/releases
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> As there was a bug in QWebKit regarding "unload" event. We have
>>>>>>>>> raised and also they have provided patch file to fix this issue. I have
>>>>>>>>> applied the patch in linux and compile the webkit and tested the attached
>>>>>>>>> patch with compiled webkit which is now working fine.
>>>>>>>>>
>>>>>>>>> Below is the link for reference regarding unload issue. They have
>>>>>>>>> provided test webkit release for Mac in below URL but for other platform we
>>>>>>>>> need to apply the patch and compile the webkit until they provide
>>>>>>>>> webkit-releases for all platforms.
>>>>>>>>>
>>>>>>>>> https://github.com/annulen/webkit/issues/519
>>>>>>>>>
>>>>>>>>> Do review it and let me know in case of any issue.
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Neel Patel
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Sent via pgadmin-hackers mailing list (
>>>>>>>>> pgadmin-hackers(at)postgresql(dot)org)
>>>>>>>>> To make changes to your subscription:
>>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Page
>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>> Twitter: @pgsnake
>>>>>>>>
>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> *Akshay Joshi*
>>>>>>> *Principal Software Engineer *
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>>>>>> 976-788-8246 <+91%2097678%2088246>*
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> VP, Chief Architect, Tools & Installers
>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Akshay Joshi*
>>>>> *Principal Software Engineer *
>>>>>
>>>>>
>>>>>
>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>>>> 976-788-8246 <+91%2097678%2088246>*
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> VP, Chief Architect, Tools & Installers
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>
>

--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake