Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
Cc: Matthew Kleiman <mkleiman(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>
Subject: Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling
Date: 2017-07-21 12:34:11
Message-ID: CA+OCxox7+Vn2u9RUYrxdB1_NQ0W=h_Snn2Hao_QLRwKMjVeqEw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

And... applied. Thanks.

On Fri, Jul 21, 2017 at 1:28 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

>
>
> On Fri, Jul 21, 2017 at 12:34 PM, Harshal Dhumal <
> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>
>>
>>
>> On Jul 21, 2017 4:23 PM, "Dave Page" <dpage(at)pgadmin(dot)org> wrote:
>>
>>
>>
>> On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal <
>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> On Fri, Jul 21, 2017 at 2:24 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Hi
>>>>
>>>> On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal <
>>>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Currently if user clicks on empty white area below history entry then
>>>>> arrow navigation does not work.
>>>>> Attached patch fixes this issue.
>>>>>
>>>>
>>>> This fixes that problem, but stops it working if I *don't* click on the
>>>> white area first. We need both I think :-)
>>>>
>>> Yes we need both. Please find updated patch
>>>
>>
>> Why all the changes to yarn.lock?
>>
>> Are there? I can't see any changes.
>>
>
> Huh, no, you're right. Looks like my machine is rewriting it for some
> reason. I'll dig deeper.
>
> Sorry for the noise.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2017-07-21 13:06:38 [pgAdmin4][patch][RM#2593]: Query Tool/ Debugger won't load with Qt-5.1 with webkit
Previous Message Dave Page 2017-07-21 12:34:03 pgAdmin 4 commit: Ensure arrow keys work correctly when the pane is foc