Re: PATCH: Wait for the thread only if it is running

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Wait for the thread only if it is running
Date: 2013-07-08 13:48:09
Message-ID: CA+OCxox5-R+w9wnq+4qGC+a2BBt44MmNGKAaPzOyU8KXBVW0sA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - patch applied.

On Mon, Jul 8, 2013 at 6:03 AM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com>wrote:

> Found couple of more issues in the same area.
> - Forgot to set variable to NULL after deleting it
> - Removed redundant code
> - Canceling the thread execution only if the thread is running
>
> Attached is the updated patch.
>
> On Fri, Jul 5, 2013 at 2:41 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> I have modified the code a little bit for the ctlSQLResult and debugger,
>> so that it will wait for the thread only if it was running.
>> It should resolve the issue reported in the following mail thread.
>> http://www.postgresql.org/message-id/E7BD3DF3326743FC867EDDB5D2446840@O
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>>
>
>
>
> --
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>
>
>
> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2013-07-08 13:52:54 pgAdmin III commit: Fix a number of issues with debugging on older vers
Previous Message Dave Page 2013-07-08 13:47:57 pgAdmin III commit: Only attempt to cancel query threads that are actua