Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY
Date: 2019-06-26 14:52:35
Message-ID: CA+OCxox4VmAtwvWmZdZ9a=1KyR5yKDSQPTEi7rjahqfEAVWh_w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

Something isn't working correctly - I turned on the summary option, and
this is the query that was run when I hit the EXPLAIN button:

EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING
False,SUMMARY False,BUFFERS False) select * from pg_tables

Aside from the formatting (s/True/true, s/False/false, missing spaces etc),
shouldn't it say SUMMARY true? I've cleared the browser and bundle caches,
rebundled etc.

Shouldn't there also be documentation updates?

On Wed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch to add support for SETTINGS(v12+) and SUMMARY(v10+)
> explain options. These options will be visible only if version is supported.
>
> I have also created and fixed RM4395. The explain options changed on one
> query tool should not change explain options on other query tools or
> preferences. The initial values will be taken from preferences are usual.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Alex Kim 2019-06-26 19:30:04 Re: Getting Involved
Previous Message Dave Page 2019-06-26 12:32:06 Re: [GSoC][Patch] Automatic Mode Detection V1