Re: Minor patch to fix reggression of select2 option

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Subject: Re: Minor patch to fix reggression of select2 option
Date: 2019-04-30 11:58:28
Message-ID: CA+OCxox4PoiyOoOgChX0XrjwtJaLESMJUiP+cqpaY3V+2p7+NQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

Note to Akshay: When you tag 4.6, please make sure it is on the correct
commit, and if we need to rewrap, you may need to move this issue to the
4.6 release notes.

Thanks!

On Tue, Apr 30, 2019 at 9:22 AM Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
wrote:

> Hi Dave,
>
> RM is 4218 <https://redmine.postgresql.org/issues/4218>
>
> Thanks,
> Neel Patel
>
> On Tue, Apr 30, 2019 at 1:25 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> What's the RM for this?
>>
>> On Tue, Apr 30, 2019 at 8:00 AM Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
>> wrote:
>>
>>> Hi Team,
>>>
>>> Please find attached patch to fix the issue where we should properly
>>> assigned 'dropdownParent' select2 options.
>>>
>>> This was regression of commit 6016a5ee989a8f3f56c4a03994eb57989c3c0717
>>>
>>> Do review it and let us know for comments.
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2019-04-30 12:57:15 pgAdmin 4 commit: Ensure popper.js is installed when needed. Fixes #421
Previous Message Dave Page 2019-04-30 11:57:22 pgAdmin 4 commit: Properly assign dropdownParent in Select2 controls. F