Re: [pgAdmin4][Patch]: RM #2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret

Thanks, patch applied.

On Wed, Jan 17, 2018 at 6:55 AM, Khushboo Vashi
<khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>
> On Wed, Jan 17, 2018 at 12:23 PM, Khushboo Vashi
> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>
>>
>> On Mon, Jan 15, 2018 at 10:39 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>> Hi
>>>
>>> On Mon, Jan 15, 2018 at 10:23 AM, Khushboo Vashi
>>> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> Please find the attached patch for RM # 2904: As a visually impaired
>>>> user I need all buttons in the application to have appropriate tooltips for
>>>> my screen reader to interpret.
>>>
>>>
>>> Unfortunately I think there's been a misunderstanding with this patch,
>>> most likely my fault for not being clearer;
>>>
>>> - There is no need to add tooltips to buttons that already have text,
>>> unless we want to add additional information. For example, on the OK button,
>>> we might have a tooltip that says "Apply the changes and close the dialog".
>>> That really is optional though, as screen readers could already read the
>>> button text (but we should be consistent).
>>>
>>> - We do need to add tooltips to buttons that don't have any text. For
>>> example;
>>> * dialogue title-bar buttons
>>> * the "close tab" and "move tabs left"/"move tabs right" buttons
>>> that may appear in tab bars
>>> * the add row button at the top of a subnode control (e.g. to add a
>>> column definition)
>>> * the delete and expand row buttons in subnode grid rows
>>>
>>> Sorry for not being clearer about the requirements.
>>>
>> Thanks for the clarification.
>> Please find the attached updated patch.
>
> Missed attachment. Please find it attached.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company