Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion
Date: 2018-06-14 07:44:18
Message-ID: CA+OCxox1t8LR7byMFmNSexxxoVhLw6n6o3AbAoSV46ci8mDPuA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

> Hi Hackers,
>
> Attached is the patch for the Feature #2686 Property to switch lower/upper
> case auto completion. I have added new preferences settings "Keywords in
> uppercase" if it is set to True then all the keywords are shown in upper
> case in auto completion.
>
> I have also implemented the second request in the RM to change the
> selected text to upper/lower case. For that I have added new keyboard
> shortcut "Toggle case of selected text" in preferences dialog. Default
> key is "Ctrl + Shift + u".
>
> Please review it.
>

I don't see any doc updates in the patch - seems like that was forgotten?

Any opportunities to re-factor the code in that area into more testable
functions?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-06-14 07:50:07 Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted
Previous Message Akshay Joshi 2018-06-14 07:41:42 [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion