Re: RM4292 - Dark mode support for Windows/macOS

Ah, OK. Cool :-)

On Wed, Apr 22, 2020 at 12:55 PM Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
wrote:

> yes, as i have tested on my local env without those files and it worked.
> So now those staging files for dark themes are not required ( *.qss,
> dark/*.svg, light/*.svg etc ) as qss are bundled within the application
> itself. If we copy those files along with the application and change the
> QSS, it is not affecting any Qt controls. At compile time, whatever the qss
> embedded to application, that will be applied.
>
> Thanks,
> Neel Patel
>
> On Wed, Apr 22, 2020 at 5:12 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Doesn't that revert the previous patch that copied all the required files
>> into the staging directory?
>>
>> On Wed, Apr 22, 2020 at 12:40 PM Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
>> wrote:
>>
>>> Hi,
>>>
>>> After debugging, I found that the required image formats Qt plugin was
>>> missing in bundling and due to that "checkbox" images or all images were
>>> not rendered from qss files. It was working fine in my local development
>>> environment because all required plugins to load the images are present. I
>>> have attached the patch for windows and Mac. Can you please review ? I will
>>> verify once snapshot build is available.
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>> On Mon, Apr 20, 2020 at 7:19 PM Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Thanks, patch applied without testing it.
>>>>
>>>> On Mon, Apr 20, 2020 at 6:59 PM Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
>>>> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> In windows, I am able to reproduce it with my dev environment and
>>>>> after copying "Qt5Svg.dll", it renders the checkbox and for Mac build, we
>>>>> should copy theme components in "Resources" folder which might solve the
>>>>> problem and update the patch accordingly.
>>>>> Once snapshot build is ready, I will verify with the same. Do review
>>>>> it.
>>>>>
>>>>> Thanks,
>>>>> Neel Patel
>>>>>
>>>>> On Wed, Apr 15, 2020 at 7:12 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Wed, Apr 15, 2020 at 2:11 PM Neel Patel <
>>>>>> neel(dot)patel(at)enterprisedb(dot)com> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> On Wed, Apr 15, 2020 at 5:04 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>>>
>>>>>>>> Hi
>>>>>>>>
>>>>>>>> On Thu, Apr 9, 2020 at 5:56 PM Neel Patel <
>>>>>>>> neel(dot)patel(at)enterprisedb(dot)com> wrote:
>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>> - Checkbox is not visible in Configure window UI as per
>>>>>>>>>>> below screenshot. Are you able to see on Mac ? If no, I can take a look at
>>>>>>>>>>> it.
>>>>>>>>>>>
>>>>>>>>>>> [image: Screenshot 2020-04-09 at 5.05.25 PM.png]
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> No, that works on Mac. If you can look at it that would be great
>>>>>>>>>> (are the SVGs from the patch in your filesystem?):
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Yes, all SVGs from the patch are there. I will take a look.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> [image: Screenshot 2020-04-09 at 17.47.39.png]
>>>>>>>>>>
>>>>>>>>>
>>>>>>>> So interestingly, with the snapshot build I now see this:
>>>>>>>>
>>>>>>>> [image: Screenshot 2020-04-15 at 12.34.02.png]
>>>>>>>>
>>>>>>>> Any idea what's going on?
>>>>>>>>
>>>>>>>
>>>>>>> All svg files and qss reside along with the application ?
>>>>>>> Initially I got this issue and when I copied the qss and svg files
>>>>>>> along with the application, it resolved the issue but again I will
>>>>>>> double-check and update on this.
>>>>>>>
>>>>>>
>>>>>> Actually, no - I don't see them in the appbundle.
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>>
>>>> *Sr. Software Architect*
>>>> *EnterpriseDB Software India Private Limited*
>>>> *Mobile: +91 976-788-8246*
>>>>
>>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company