Re: [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards
Date: 2017-04-11 10:58:41
Message-ID: CA+OCxox0jeTjqfDtO=swntWQJcjurMv7jmTAr_HLdv-ETmRHMw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Apr 11, 2017 at 10:51 AM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> When a server is disconnected, listen to 'pgadmin:server:disconnect'event
> and trigger refresh button of Server Activity data.

I don't see any reason to do that - it's not auto-refreshed data, so
why clear it?

> Also, on server disconnect, an unused event 'server-disconnected' is being
> triggered.
> instead it should trigger ''pgadmin:server:disconnect'event.

Please submit that as a separate cleanup patch.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2017-04-11 12:23:26 Re: [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards
Previous Message Surinder Kumar 2017-04-11 09:51:58 [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards