| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: "yarn run pep8" excludes config file |
| Date: | 2019-03-22 09:05:54 |
| Message-ID: | CA+OCxox+Jc8AmKmz46cZARV90VcMdjg1DC74QNXZY5=WRVCh7Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Fri, Mar 22, 2019 at 8:52 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Hackers
>
> After latest pull when I run "*yarn run pep8*" from *web* directory it is
> not working properly. Path of the ".pycodestyle" config file is not correct
> in package.json. Attached is the patch to fix that.
>
Wow, why do we even have a pep8 check in there? Anyway, I've committed a
fix, but changed it to run in the same directories as the Makefile scans,
otherwise it would have picked up staging directories for builds and they
can contain venvs with other Python modules in them.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2019-03-22 09:36:17 | pgAdmin 4 commit: Use the user's full email address (not just the usern |
| Previous Message | Dave Page | 2019-03-22 09:04:23 | pgAdmin 4 commit: Fix the PEP8 yarn runner |