Re: SCSS change for reset button and help text

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Shubham Agarwal <shubham(dot)agarwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: SCSS change for reset button and help text
Date: 2018-11-29 15:36:21
Message-ID: CA+OCxowyqOaw_7QJ-w89R=MbQ1X31L7g263HEsKUqOOaAqATew@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Thu, Nov 29, 2018 at 6:55 AM Shubham Agarwal <
shubham(dot)agarwal(at)enterprisedb(dot)com> wrote:

> Hi Team,
> Please ignore the previous patch and find the updated patch with one more
> additional change of displaying the Not allowed pointer
> on the disabled or read only text controls.
>
> On Tue, Nov 27, 2018 at 5:12 PM Shubham Agarwal <
> shubham(dot)agarwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Team,
>>
>> I have observed below discrepancies related to bootstrap 4 while testing
>> which are fixed in the attached patch:-
>>
>> 1. Text in 'Reset button in any wizard is displaying in black colour and
>> colour for the rest of the buttons like 'Save' and 'Cancel' is white.
>> 2. On Hovering on the disable button the mouse pointer was not changing
>> to the not allowed pointer.
>> 3. Minor fix for Help text.
>>
>
I can't reproduce 1 (testing in the Grant Wizard), and 2 is normal. Most
apps don't change the mouse pointer for disabled buttons.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-11-29 15:47:52 pgAdmin 4 commit: Add titles to the code areas of the Query Tool and De
Previous Message Akshay Joshi 2018-11-29 12:43:11 pgAdmin 4 commit: Tag REL-3_6 has been created.