Re: Autoformatting

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Raffi Holzer <rholzer(at)pivotal(dot)io>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Autoformatting
Date: 2017-02-14 10:53:00
Message-ID: CA+OCxowyMCS4DJBWm1sN-iAudt05Bii88mbxu-SPXRAK35S7jA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Mon, Feb 13, 2017 at 9:35 PM, Raffi Holzer <rholzer(at)pivotal(dot)io> wrote:
> Hi Hackers,
> We are looking into auto formatting SQL text in the SQL editor. However,
> some users have expressed that this can be done in different ways. Are there
> preferences in this community fo rhow autoformatting should be done?

I think that really depends on the specific feature being discussed.
For example, auto-indentation is very handy, and whilst it (and most
formatting features) should be configurable, I suspect many people
will leave it turned on. On the other hand, something like
auto-upper-casing of keywords may be either automatic, or shortcut
initiated, e.g. hit Ctrl+U to upper-case the word under the cursor.

Perhaps you should start by listing the specific features? For
reference, here's what pgAdmin 3 had:

* The auto-indent feature will automatically indent text to the same
depth as the previous line when you press return.
* Block indent text by selecting two or more lines and pressing the Tab key.
* Block outdent text that has been indented using the current tab
settings using Shift+Tab.
* Comment out SQL by selecting some text and pressing the Control+K.
* Uncomment SQL by selecting some text starting with a comment and
pressing Control+Shift+K.
* Shift the selected text to upper case by pressing Control+U.
* Shift the selected text to lower case by pressing Control+Shift+U.

pgAdmin 4 currently has:

* Auto-indent (not currently possible to disable it)

I'd definitely like to see the rest (and anything else that seems
useful) added, and made configurable where appropriate. I suspect the
only ones that should be truly automatic are auto-indent and and
upper-casing of keywords.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Atira Odhner 2017-02-14 14:39:30 Re: Feature Suggestions
Previous Message Dave Page 2017-02-14 10:30:05 Re: [patch] Fixes QT build when not signing