From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
Cc: | Mickael Deloison <mdeloison(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue) |
Date: | 2013-05-09 18:53:35 |
Message-ID: | CA+OCxowxnWpZ2uCfzrzNyYOxM7e47rqRp1aZ44W_5LjDtA=pyA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Thu, May 9, 2013 at 7:34 PM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
> On 9 May 2013 20:43, "Dave Page" <dpage(at)pgadmin(dot)org> wrote:
>>
>> OK, I've pushed this as-is for now. We'll remove the pgscript CLI in a few
>> days if noone exists.
>>
>> I had a couple of other thoughts whilst playing with VPATH builds -
>> shouldn't the doc and png2c output (*.pngc) be redirected to
>> $(top_builddir), or is there a reason we don't currently do that? Can you
>> check that please?
> Yeah - I tried that... and, I m aware of that.. But - forgot to mention that
> here.
> As I could not give more time, I've fixed only upto this level, so that -
> nothing is broken..
>
> Atleast - creation of the png2c binary & using it from the builddir has been
> taken care in my previous patch..
>
> I'll spend some more time after few days....
> I've something else with more priority in my plate. :(
Probably also my fault, so no problem :-). This is low priority.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2013-05-13 11:25:40 | Re: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue) |
Previous Message | Ashesh Vashi | 2013-05-09 18:34:59 | Re: PATCH: Add libssh2 directory in CPPFLAGS (VPATH issue) |