Re: [pgAdmin4][RM3478] User should able to type any query in SQL Filter

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM3478] User should able to type any query in SQL Filter
Date: 2018-07-09 13:11:09
Message-ID: CA+OCxowx+fnVfsPv2fDOX6f0i-orRm4Dqt_he5TJ=oP4VCfSYA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Mon, Jul 9, 2018 at 1:12 PM, Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> ​Hi Hackers,
>
> Attached is the patch to fix the issue where SQL area in filter dialog was
> not allowing to type. Actually it was allowing to type but the font size of
> the SQL area was 0em and so the characters were not visible. This bug
> occurred because of RM3294 <https://redmine.postgresql.org/issues/3294>
> patch 0001 ​which I had sent previously.
>
> Also, fixed a small typo in
> ​ ​
> pgadmin/utils/preferences.py
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2018-07-10 07:14:06 [pgAdmin4][patch] jQuery 3 migration few more leftovers
Previous Message Dave Page 2018-07-09 13:08:46 pgAdmin 4 commit: Ensure text is visible in the SQL Filter dialogue. Fi