| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
| Cc: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: Fix context menu fontawesome icons |
| Date: | 2017-09-15 12:56:32 |
| Message-ID: | CA+OCxowvQogn-WyMih+0JvahrvaOLMiuFdy+20u8w26+tbuHog@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
On Fri, Sep 15, 2017 at 8:52 AM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi Ashesh,
>
> PFA minor patch to fix the font-awesome icon layout issue, attaching
> screenshot of an issue for your reference.
>
> Regression of your commit: Link
> <https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=blobdiff;f=web/pgadmin/static/css/bootstrap.overrides.css;h=b6d50eb274ee1b7e05bf4b195407ca8ae9b03097;hp=f4d21b338691c69d055cfa9820f8fd1037afbd90;hb=3bbd1a8a48aac6a1f2b72dbe951f58fc32ed3bda;hpb=8b1aeadaf0347fb27bc7756cdf03aad32d03f3da>
>
I'm not sure this is the right way to fix this. We should re-add the left
hand margin on the buttonbar menus and top-level menus. That's consistent
with what the context menu looks like, but more importantly it's also
consistent with (at least) macOS.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2017-09-15 13:08:33 | pgAdmin 4 commit: Replace the "Roboto" font family with "Open Sans" for |
| Previous Message | Dave Page | 2017-09-15 12:50:47 | Re: [pgAdmin4][Patch]: pgAdmin4 not displaying schema if it start with 'pg' |