Re: [pgAdmin4][Patch]: RM #3676 Issue with the pgAdmin create script for the function wrapped with edbwrap

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM #3676 Issue with the pgAdmin create script for the function wrapped with edbwrap
Date: 2018-10-29 11:54:52
Message-ID: CA+OCxowuORusUVyZqY=iShrxTZvqXPb+wFXMR5ee9j8hWHvOJg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Mon, Oct 29, 2018 at 7:01 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Hackers,
>
> Attached is the patch to fix RM #3676 Issue with the pgAdmin create
> script for the function wrapped with edbwrap. Actual cause of the issue
> is an extra blank line after "*$__EDBwrapped__$*" statement, while taking
> backup of such function will throw an error invalid wrapped string.
>
> I have fixed the issue by removing extra blank line from the jinja
> templates. Please review it.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-10-29 14:17:36 pgAdmin 4 commit: Update to latest Flask, to avoid a security issue.
Previous Message Dave Page 2018-10-29 11:54:15 pgAdmin 4 commit: Fix CREATE Script functionality for EDB-Wrapped funct