Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog
Date: 2018-05-31 14:10:54
Message-ID: CA+OCxowstz6v_ETF7j8AE3qzvPeix2_F+CJezjt6DpvH=4YJ6Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch pushed.

On Wed, May 30, 2018 at 9:26 AM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA minor patch to fix the issue when you change any field in server
> dialog 'tunnel_identity_file' model value get included unnecessarily in the
> update request.
>
> eg: Change the server name and click on Save button, Check the request
> payload in network console.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-05-31 14:27:33 pgAdmin 4 commit: Bind the container server to ipv6 as well as ipv4 por
Previous Message Dave Page 2018-05-31 14:10:48 pgAdmin 4 commit: Fix an issue where a change to any field in server di