Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid
Date: 2017-07-24 10:53:30
Message-ID: CA+OCxows56jVtkaaEGWHZoh_psFoyfiPTcehe5mOf5+KiKs56A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Mon, Jul 24, 2017 at 11:34 AM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find attached patch to set default layout of file listing as a list
> in file manager.
> Also replaced alertify with out custom alertifywrapper in file manager
> utils.js
>

This isn't a bad idea on the face of it, but there are some things to
fix/consider:

- The HTML file seems to be missing translation markers. Can you add them
throughout please?
- We should save the users preference in the config database.
- The grid view seems to underline the file size and for no apparent reason
change the mouse cursor to ? on mouseover. Let's change the text style to
be consistent and get rid of the mouseover.

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin 4 Jenkins 2017-07-24 11:13:19 Jenkins build is back to normal : pgadmin4-master-python36 #257
Previous Message Dave Page 2017-07-24 10:46:22 Re: [pgadmin-hackers][patch]