Re: [pgAdmin4][RM3371] Ping endpoint still send a pg4a_session cookie

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM3371] Ping endpoint still send a pg4a_session cookie
Date: 2018-07-02 14:59:17
Message-ID: CA+OCxownog76MyFfquLY7na_i9LtY4-h2FX6duJos1fKwAPMRg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

I'm not in a position to test at the moment, but can you confirm this will
work if the root of pgAdmin is at (for example) /pgadmin? So the actual
root is /pgadmin/misc/ping ?

On Mon, Jul 2, 2018 at 1:35 PM, Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch for fixing RM3371 where /misc/ping service generate
> session file for each call and so cannot be used frequently.
> The patch is to skip session file generation and session caching for the
> URLs provided in SESSION_SKIP_PATH list config parameter.
> pg4a_session_cookie value will still be generated but nothing will be
> stored at the backend.
> Also, I have separated the garbage collection code in current ping service
> to a new url /misc/cleanup. /misc/ping will be purely for is alive check.
>
> Request you to kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-07-02 15:28:20 pgAdmin 4 commit: Build the electron runtime in the standard build dirs
Previous Message Dave Page 2018-07-02 14:56:09 Re: [pgAdmin][Patch]: Fixed RM #3362 - Database restore utility does not honour restore options for sections