Re: Documentation patch

On Wed, Mar 5, 2014 at 9:27 AM, Akshay Joshi
<akshay(dot)joshi(at)enterprisedb(dot)com>wrote:

> Hi
>
> I have reviewed the patch. It is working fine on Linux, but on Windows it
> is not compiling gives "*initialization of 'helppath' is skipped by
> 'case' label*" error in misc.cpp (line no 735).
>

Hi

Thanks. I'm not sure if Ads will have a Windows build environment available
to him or not. Is it a simple fix?

>
>
> On Tue, Mar 4, 2014 at 3:21 PM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Sure
>>
>>
>> On Tue, Mar 4, 2014 at 3:16 PM, Ashesh Vashi <
>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Akshay,
>>>
>>> Can you please take a look at this?
>>>
>>>
>>> On Tue, Mar 4, 2014 at 3:15 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Ashesh, can you have someone look at this and Ads' other patch please?
>>>>
>>>> Thanks.
>>>>
>>>> On Mon, Mar 3, 2014 at 11:00 PM, Andreas 'ads' Scherbaum
>>>> <adsmail(at)wars-nicht(dot)de> wrote:
>>>> >
>>>> > Hi,
>>>> >
>>>> > while scrolling through the pgAdmin3 code I found some places where
>>>> the
>>>> > Greenplum links are outdated. The attached patch fixes this.
>>>> >
>>>> > Note: the current code will update the configuration and write a new
>>>> link.
>>>> > Not sure if this is the best thing to do, or just replace the link on
>>>> the
>>>> > fly.
>>>> >
>>>> > Also the patch does a better searching for documentation, by looking
>>>> up all
>>>> > possible installed Greenplum versions. Not exactly sure when
>>>> __WXMSW__ is
>>>> > set - this path is not optimized (pgAdmin3.cpp, around line 1417), I
>>>> just
>>>> > added a few updated directories.
>>>> >
>>>> >
>>>> > Regards,
>>>> >
>>>> > --
>>>> > Andreas 'ads' Scherbaum
>>>> > German PostgreSQL User Group
>>>> > European PostgreSQL User Group - Board of Directors
>>>> > Volunteer Regional Contact, Germany - PostgreSQL Project
>>>> >
>>>> >
>>>> > --
>>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org
>>>> )
>>>> > To make changes to your subscription:
>>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>>> >
>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>>
>>> --
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>>>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517> Mobile: +91 976-788-8246
>> <%2B91%20976-788-8246>*
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517> Mobile: +91 976-788-8246
> <%2B91%20976-788-8246>*
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company