Re: Accessibility issues in PgAdmin

On Mon, Mar 15, 2021 at 10:02 AM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> On Mon, Mar 15, 2021 at 2:52 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>> On Mon, Mar 15, 2021 at 4:58 AM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> On Sat, Mar 13, 2021 at 12:42 AM <timjonas(dot)boettcher(at)gmx(dot)de> wrote:
>>>
>>>> Hello,
>>>>
>>>>
>>>>
>>>> I discovered an accessibility issue in PgAdmin:
>>>>
>>>> All toggle buttons (eg. used to grant or revoke a role’s rights or
>>>> adjust the app’s behaviour in preferences) are labelled as toggle buttons
>>>> and their yes/no, true/false state gets reported correctly, but do not have
>>>> the appropriate WAI-ARIA roles (role="button" and
>>>> aria-pressed="true/false").
>>>>
>>>> Therefore, they do not actually behave like toggle buttons (to a screen
>>>> reader, they are simply text). Moreover, the buttons only respond to
>>>> mouse-clicks on … I don’t even know, because my braille display only shows
>>>> empty space at the spot where one would need to click.
>>>>
>>>>
>>>>
>>>> Is there, perhaps, a keyboard shortcut/mnemonic to toggle the buttons?
>>>> Or do all of you simply use the mouse?
>>>>
>>>>
>>>>
>>> Use a space button to toggle the yes/no or true/false buttons.
>>>
>>>> If the latter: Is the pgadmin-hackers mailing list the right spot for
>>>> feature requests/patch requests or is there a GitHub repository where I
>>>> could post the issue?
>>>>
>>>>
>>>>
>>> Use https://redmine.postgresql.org/projects/pgadmin4 to log the request
>>> in future.
>>>
>>
>> Khushboo, can you please make sure the appropriate WAI-ARIA roles are
>> added ASAP?
>>
> We have added Area label and role for toggle button but did not added for
> the labels which state yes/no as we have marked them as area-hidden=true,
> so that they can be excluded from the accessibility tree.
> As we have added appropriate WAI-ARIA for the toggle button (parent div),
> the screen reader can read that control as a toggle button (I have tested
> it with Chrome Screen reader extension) and not only text.
> Also, we have provided a spacebar key to toggle it, so we can operate it
> with a keyboard.
>
> [image: Screen Shot 2021-03-15 at 3.30.02 PM.png]
>

OK, that's good - however, it's obviously not working for Tim's braille
display. Can you please try to get to the bottom of it? Maybe we need to
whip up a simple test case that Tim can try out, as we don't have access to
any braille devices and couldn't read them anyway.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com