Re: [pgAdmin4][Patch]: Delete row server error not shown to GUI user

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Delete row server error not shown to GUI user
Date: 2017-05-02 11:20:40
Message-ID: CA+OCxowgD-fV9K+1J4-=wNMJw8qn0rhx7gD6=OsTYQ4=KFhesA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Fri, Apr 28, 2017 at 11:48 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> Hi
>
> The variable list_of_rowid doesn't keep track of rows to be deleted.
> If this list is empty simply return 0 since '_rowid' is being used to
> highlight the row for which error is occurred in only insert and update
> operation.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-05-02 11:51:13 Re: [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values
Previous Message Dave Page 2017-05-02 11:20:34 pgAdmin 4 commit: Ensure errors thrown when deleting rows in the query