From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Jonas Thelemann <e-mail(at)jonas-thelemann(dot)de> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: .gitignore Improvement Suggestion |
Date: | 2017-01-16 09:41:14 |
Message-ID: | CA+OCxowfyg+aRnwZy1d=U+z7Sa9pY7kjwBu5DGXh-StOcFzmDA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Sun, Jan 15, 2017 at 4:00 AM, Jonas Thelemann
<e-mail(at)jonas-thelemann(dot)de> wrote:
> Good day pga-hackers,
>
> while playing around with the source and Git I found out that building an
> executable on my Raspberry Pi creates a file called "pgAdmin4" in the
> runtime folder. The .gitignore file in the same folder only mentions a
> "pgadmin4" file without a capital "a" in its name.
>
> As I'm new to this project it could well be that this was changed in one of
> the last commits of which I have no knowledge. Because it's just a small
> change to fix this potentially new and probably unwanted error I attached
> the fix to this mail. I also put all lines in the .gitignores in
> alphabetical order to make them easier to read and to prevent duplicate
> lines.
>
> No matter if only the real fix is going to get accepted or the reordering
> too: did I submit the .diff (patch) correctly? I'm new to Git via the
> command line as you already know. Please tell me, if I made any mistakes.
It all looks good to me - patch committed, thanks!
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Usama Tariq | 2017-01-16 09:55:49 | Need Help Regarding phppgadmin4 on Ubuntu server 16.04 |
Previous Message | Dave Page | 2017-01-16 09:17:52 | pgAdmin website commit: Update public key. |