| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
| Cc: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00 |
| Date: | 2018-02-21 17:21:55 |
| Message-ID: | CA+OCxowewcNdbkyHe-1Y0w3HA3R_eTKA5mBKDvF48PArj4pp0Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Wed, Feb 21, 2018 at 3:45 PM, Joao De Almeida Pereira <
jdealmeidapereira(at)pivotal(dot)io> wrote:
> Hi
> The patch looks good, do we have any example error that we can test in
> order to ensure the problem no longer shows up in the future?
> If they could be Unit Tests instead of Feature tests that would be
> awesome, because Feature tests are much more expensive then Unit.
>
I think we need to consider a couple of options here:
1) Make sure that many/all of our tests use non-ASCII names.
2) Consider adding a mechanism to allow running the regression tests with
overridden GUC values. For example, a parameter in the test config file
that gives a set of GUCs to change upon connection.
The downside of 2 of course, is that it adds a huge amount of possible
environment combinations to test.
Thoughts?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joao De Almeida Pereira | 2018-02-21 17:29:01 | Re: RM2898 Keyboard navigation in dialog tabs (nav tabs) |
| Previous Message | Dave Page | 2018-02-21 17:18:16 | Re: [pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00 |