| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_ls_waldir() & pg_ls_logdir() |
| Date: | 2017-03-16 10:09:47 |
| Message-ID: | CA+OCxoweEO98gWOsBDD5T0SgdEwPk7ChVz-A7wae1dnLNOeOwA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 16, 2017 at 9:54 AM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> On Thu, Mar 16, 2017 at 10:40 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>> + const int n = snprintf(NULL, 0, "%lld", attrib.st_size);
>
> I wonder what the portable printf directive is for off_t. Maybe
> better to use INT64_FORMAT and cast to int64?
Hmm, good point. Google seems to be saying there isn't one. Patch
updated as you suggest (and I've added back in a function declaration
that got lost in the rebasing of the last version).
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| lsdir_v3.diff | text/plain | 8.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikhil Sontakke | 2017-03-16 10:18:18 | Re: Speedup twophase transactions |
| Previous Message | Amit Langote | 2017-03-16 10:03:29 | Re: Partitioned tables and relfilenode |