Re: Translations: Newline / Whitespace Fix

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Jonas Thelemann <e-mail(at)jonas-thelemann(dot)de>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Translations: Newline / Whitespace Fix
Date: 2017-03-27 00:32:00
Message-ID: CA+OCxowbpd+i0jTv1VvSxekj77tzRtMb4PxkvUo=HfJa_0J_Bw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Sun, Mar 26, 2017 at 8:15 PM, Jonas Thelemann
<e-mail(at)jonas-thelemann(dot)de> wrote:
> Good morning pgAdmin-hackers,
>
> I removed three occurences of unnecessary newlines / whitespaces in
> __init__.py files, which prevented alphabetical sorting of translatable
> strings in poEdit.

Thanks - applied.

> Question: In such .diffs like the attached, should I include the updated and
> compiled strings in .pot and .mo files?

No, I'll typically re-merge/rebuild them as part of the commit.

However - there's a bug at the moment due to some in-progress long
term work to move javascript translations into the client, which is
preventing me doing that.

I'll ping the person who was going to get it sorted to see if I can
speed up the fix.

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-03-27 00:33:20 Re: Javascript translations
Previous Message Dave Page 2017-03-27 00:27:41 pgAdmin 4 commit: Remove some unnecessary line breaks causing problems