From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][PATCH] To fix the issues with CSV file download |
Date: | 2017-05-12 09:38:32 |
Message-ID: | CA+OCxowbgwC5x_svRNv-z4hsxG8etGOXX2CnKiygKYPV8QFx4A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks - patch applied.
On Thu, May 11, 2017 at 3:21 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> Please find patch to handle non-ascii column names in CSV for Pyhton2.
>
> Thanks to Harshal for pointing out the issue.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, May 8, 2017 at 6:06 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Thanks, patch applied.
>>
>> On Mon, May 8, 2017 at 1:14 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find the patch to fix the issues in CSV file download feature,
>>>
>>> 1) To handle non-ascii filenames which we set from table name
>>> RM#2314
>>>
>>> 2) To handle non-ascii query data
>>> RM#2353
>>>
>>> 3) To dump JSON type columns properly in csv
>>> RM#2360
>>>
>>> Please review.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-05-12 09:39:39 | Re: [pgAdmin4][PATCH] To fix the issue with Node rename |
Previous Message | Dave Page | 2017-05-12 09:38:27 | pgAdmin 4 commit: Properly handle non-ASCII column names in CSV. Fixes |