From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: PGADMIN 4 - FTS templates node |
Date: | 2016-04-07 14:02:14 |
Message-ID: | CA+OCxowac14pFzFKuexhTxt3w3b=X3JMKwFsP5eV0z7MDdD6jw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks - committed.
On Thu, Apr 7, 2016 at 2:47 PM, Sanket Mehta
<sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Sorry about that issue,
>
> Its resolved now.
>
> PFA the right patch with this mail.
>
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Thu, Apr 7, 2016 at 2:39 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> On Mon, Mar 28, 2016 at 10:01 AM, Sanket Mehta
>> <sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
>> > Hi Dave,
>> >
>> > I have found out the root cause of this issue.
>> >
>> > This issue is occurring at your side as you are using python 2.7 so in
>> > that
>> > case sql query returned from sql template is of type 'unicode'.
>> > And in __init__.py file we have checked if the sql query is of string
>> > type
>> > then only we would proceed further.
>> >
>> > I was not getting this issue as I was using python 3.0
>> >
>> > I have resolved this issue and some other typo errors in comments and
>> > patch
>> > is attached with this mail.
>> >
>> > Please do review it and let me know in case of any issues.
>>
>> Did you send the right patch? I'm still getting the error
>> (specifically, when rendering update.sql, render_template throws an
>> exception "can't adapt type 'Undefined'")
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-04-07 14:17:06 | Re: [pgAdmin4] [Patch]: Grant Wizard |
Previous Message | Dave Page | 2016-04-07 14:02:00 | pgAdmin 4 commit: FTS Template support. |