Re: RM 4463 - MSQL test cases for domain node

Hi

On Wed, Aug 21, 2019 at 8:58 AM Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
wrote:

> Hi,
>
> Please find attached patch that will add more resql test cases and msql
> test cases for domain node.
>
> - Covered test cases for Length, Precision and Collation.
> - Also added msql test cases.
>
> While writing resql test cases for domain node, I found one more issue
> RM-4644 <https://redmine.postgresql.org/issues/4644>. I have sent
> separate patch for the same.
>

I'm getting the following error with this patch:

======================================================================
ERROR: runTest
(regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases)
Reverse Engineered SQL Test Cases
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line
126, in runTest
self.execute_test_case(scenarios)
File
"/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line
204, in execute_test_case
if not self.check_msql(scenario, object_id):
File
"/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line
329, in check_msql
object_id)
File
"/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line
178, in get_url
object_url = url_for(rule.endpoint, **options)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/flask/helpers.py",
line 356, in url_for
return appctx.app.handle_url_build_error(error, endpoint, values)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/flask/app.py",
line 2061, in handle_url_build_error
reraise(exc_type, exc_value, tb)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/flask/_compat.py",
line 35, in reraise
raise value
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/flask/helpers.py",
line 345, in url_for
force_external=external)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/werkzeug/routing.py",
line 1776, in build
raise BuildError(endpoint, values, method, self)
werkzeug.routing.BuildError: Could not build url for endpoint
'NODE-domain.msql_id' with values ['did', 'gid', 'scid', 'sid']. Did you
forget to specify values ['doid']?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company