From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM2653] Lock layout |
Date: | 2019-05-30 19:12:28 |
Message-ID: | CA+OCxowYcuidRHNSos7m7GFEK8LiPfKcD3YPwLbZmnaevdiBtg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
Can you rebase please?
(pgadmin4) dpage(at)orac:*~/git/pgadmin4*$ git apply ~/Downloads/RM2653.patch
error: patch failed: web/pgadmin/browser/static/js/browser.js:15
error: web/pgadmin/browser/static/js/browser.js: patch does not apply
On Thu, May 30, 2019 at 6:15 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is the patch to introduce feature to lock the layout with three
> different levels:
> 1) None - No locking
> 2) Prevent docking - The docking/undocking of panels will be disabled
> 3) Full lock - The resizing along with docking/undocking of panels will be
> disabled
>
> - This can be changed from new menu under File->Lock layout-><The level>
> or from Preferences->Browser->Display->Lock Layout
> - JS test cases added.
>
> With this patch I have also changed below:
> 1) Moved the maintenance dialog button group control to new common control
> named RadioModern, which I have re-used in preferences for lock layout
> levels.
> 2) Added main nav bar menu with check feature, the menus which can checked.
> 3) Ability to add submenus from existing get_own_menuitems in python code
> which is not possible currently.
> 3) Separated all the layout related functions from browser.js to new file
> layout.js to help JS testing.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2019-05-30 19:15:42 | pgAdmin 4 commit: Omit the geometry viewer in the Query Tool from layou |
Previous Message | Dave Page | 2019-05-30 14:06:17 | Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility) |