From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: Added Node Type & Catalog objects [pgAdmin4] |
Date: | 2016-03-17 10:43:01 |
Message-ID: | CA+OCxowYVt2V-sr5YQm-YDxhmNiam-4iSudNSmydu_e2_T3eMA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Thu, Mar 17, 2016 at 10:08 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
> - When editing a type, I cannot select a Grantee on the Privileges tab.
>
> This is general issue with privilege control.
> [We will add it in TODO list]
OK.
> - When adding a composite type, I cannot type/select directly in the
> grid, I have to expand the row.
>
> Because currently in Backgrid we do not have functionality like if I edit
> one cell second cell re-renders according the value of first cell,
> If we expand and select the type the other two fields (length &
> precision)are dependent on the value of type for composite types they become
> enable/disable accordingly.
That's must-have functionality. Please add a TODO for it.
> - If I click ADD to add a new member to a composite type whilst the
> previous row is expanded, the new row is added, but the expanded panel
> remains linked to the first row.
>
> - If I then click on the Edit button on the new row, I see two
> expanded panels, neither of which is attached to their row (and
> they're in the wrong order). I would only expect to see one panel at a
> time.
>
> This is general with sub-node collection control.
> [We will add it in TODO list]
OK.
> - When creating an External type, the Input, Output, Send, Receive and
> Analyze function lists are all blank. Is this expected? I would have
> thought there would be system functions listed as there are for Typmod
> in/out.
>
> Dave, I was not able to test External type functionality completely because
> it requires external type which is not inbuilt in postgres.
> Once you create that custom type using C/C++ code, it will be listed in
> those combobox by sql we are using to fetch external function types added by
> user in postgres.
I wonder if installing PostGIS would allow that testing to be done.
> - Why does "Range" type have a frame around it?
>
> So that we can make visible/hide all the control/elements related to Range
> type as whole instead having separate code for each control/element.
> That frame is because we used ‘FieldsetControl’ of backform to group all the
> elements of Range type.
Can you make it a plain div with no border/title? That would fit in
better with the existing styling, assuming the columns line up
properly.
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Harshal Dhumal | 2016-03-17 11:14:37 | Subnode grid row close issue [pgAdmin4] |
Previous Message | Murtuza Zabuawala | 2016-03-17 10:08:20 | Re: PATCH: Added Node Type & Catalog objects [pgAdmin4] |