Re: Fixed one minor issue related to "Reassign objects to"

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fixed one minor issue related to "Reassign objects to"
Date: 2013-08-05 11:59:56
Message-ID: CA+OCxowXmCVP3beDLw=-qkY9Ew0exY89GH91n1==uJfTUzAzWw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Fri, Aug 2, 2013 at 8:53 AM, Akshay Joshi
<akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
> Hi Dave
>
> I have fixed one minor issue when user right click on any login role and
> select "Reassign/Drop Owned..." context menu. When user click on "OK"
> button, but there is no role in the combo box. Attached is the screenshot of
> the error.
>
> I have fixed the issue by disabling the "OK" button if there is no role in
> the combo box. Attached is the patch file, please review it and if it looks
> good then can you please commit it.

Thanks - committed. I notice that dialogue needs some additional work
- it looks like it was thrown together with very little thought :-(.
Can you also please:

- Ensure the default position is center-owner.

- Ensure the position is saved and restored after the first usage.

- Change to a fixed-size.

Thanks Akshay.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2013-08-05 12:21:53 Fixed "Slony" related issues
Previous Message Dave Page 2013-08-05 11:56:48 pgAdmin III commit: Ensure a role is selected to reassign objects to be