From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Joao Pedro De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Sarah McAlear <smcalear(at)pivotal(dot)io> |
Subject: | Re: [patch] Correct syntax errors on Javascript test |
Date: | 2017-03-20 19:35:46 |
Message-ID: | CA+OCxowWeo7QjiENjsPP1+JGnS4YFwRA0pbt1r-kAzoZ8GVKDQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Ooops, my bad. Sorry about that - it's fixed now.
On Mon, Mar 20, 2017 at 2:01 PM, Joao Pedro De Almeida Pereira
<jdealmeidapereira(at)pivotal(dot)io> wrote:
> Hello Hackers,
> We noticed that some Python comments were added to the fake_translations.js
> file. We flushed out this issue running the Jasmine tests by doing(do not
> forget to install node dependencies instructions in web/regression/README):
>
> cd $PGADMIN4_SRC/web/
> karma start
>
>
> This patch corrects this issue.
>
> Thanks
> Joao & Sarah
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Atira Odhner | 2017-03-20 20:17:21 | Re: Feature test regression failures |
Previous Message | Dave Page | 2017-03-20 19:32:57 | pgAdmin 4 commit: Use correct file header for a JS file. |