From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | navnath gadakh <navnath(dot)gadakh(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: pgAdmin4: Patch for RM#3060 |
Date: | 2018-02-09 10:07:39 |
Message-ID: | CA+OCxowUC-yK1QVKgz3y+e90nkJCOm2v7YJfraB6jVWMDGJtAw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Fri, Feb 9, 2018 at 10:06 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> On Tue, Feb 6, 2018 at 11:49 AM, navnath gadakh <
> navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> Please find the patch for function name quoting in SQL tab for
>> functions.(RM#3060 <https://redmine.postgresql.org/issues/3060>)
>>
>> Files affected:
>> pgadmin/browser/server_groups/servers/databases/schemas/func
>> tions/__init__.py
>> pgadmin/browser/server_groups/servers/databases/schemas/func
>> tions/templates/function/pg/sql/default/get_definition.sql
>>
>> I have added code for quoting string wherever needed.
>>
>> Thanks Harshal for help!
>>
>
> Unfortunately this doesn't apply. Can you rebase it please?
>
Hold that - my tree wasn't clean...
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2018-02-09 10:15:45 | pgAdmin 4 commit: Fix quoting of function names in RE-SQL. Fixes #3060 |
Previous Message | Dave Page | 2018-02-09 10:06:34 | Re: pgAdmin4: Patch for RM#3060 |