Re: [pgAdmin4][RM4085] CSV download should show error messages in messages tab and not in the CSV file

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM4085] CSV download should show error messages in messages tab and not in the CSV file
Date: 2019-03-29 14:31:50
Message-ID: CA+OCxowTdhKTawoE14w5b5N7A0rGfrt-kU4Gz--gUeiefFDgtA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Fri, Mar 29, 2019 at 4:50 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch to handle Postgres or other errors gracefully when
> clicked on download CSV. PostgresSQL errors will be shown in messages tab
> similar to normal SQL execute.
>
> The patch also covers RM4082 (a patch is available for this on hackers,
> but this is an improved version :P. Actually I had already started working
> on this ) and RM4096.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2019-03-29 14:32:02 pgAdmin 4 commit: Display errors during CSV download from the Query Too
Previous Message Akshay Joshi 2019-03-29 14:20:53 Re: [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View."