Re: PATCH: To fix adding/updating Security Labels in various nodes (pgAdmin4)

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix adding/updating Security Labels in various nodes (pgAdmin4)
Date: 2016-07-21 15:36:05
Message-ID: CA+OCxowS959AW8-7jb4chriwc4mUCVAMrCnSGmxmQiCbZ+QCDA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Tue, Jul 19, 2016 at 3:15 PM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to fix the issue where user was not able to add/update/drop
> security labels in various nodes.
> (RM#1457)

Thanks, applied (with a minor fix to s/LABLE/LABEL/g)

It does need one minor tweak though - the provider field should be
optional; see https://www.postgresql.org/docs/9.4/static/sql-security-label.html.

Can you fix that when you get a minute please?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-07-21 16:18:20 pgAdmin 4 commit: Change button label to initcap.
Previous Message Dave Page 2016-07-21 15:35:41 pgAdmin 4 commit: Fix support for security labels. Fixes #1457