Re: [pgAdmin4][Patch]: Adding connection status in Query tool

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Adding connection status in Query tool
Date: 2017-12-19 13:54:30
Message-ID: CA+OCxowRVM=CuhKzpe0LGLArkcyK6czBOtMQb1EMEDy3ZiHFMw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

Interesting. A few thoughts:

- The pulsating icon is very off-putting. I think we need to make it only
flash a couple of times when we actually need to attract the attention of
the user.

- We shouldn't really use tooltips like this, as it may confuse folks with
screen readers. Should we make the icon clickable (which should have a
visual hint)? Maybe a drop-down status panel.

- Do we need to poll separately for the status? Instead, why not update it
whenever polling for results, or executing something?

Thanks!

On Tue, Dec 19, 2017 at 11:42 AM, Murtuza Zabuawala <murtuza.zabuawala@
enterprisedb.com> wrote:

> Hi,
>
> PFA patch to add the connection status
> <http://initd.org/psycopg/docs/extensions.html#transaction-status-constants>
> in query tool, this feature will allow user to check the database
> connection status in query tool itself, it will also provide the detailed
> status as a tooltip when user hovers on it, the most benefit of the feature
> will be when user open query tool in new Browser Tab where Browser tree is
> not visible to user, user can also configure the status polling time using
> preference dialog.
> RM#2475
>
> Apart from that I have also removed the ..sqleditor/static/css/sqledit
> or.css reference from ../datagrid/templates/datagrid/index.html file
> because we are already bundling the "sqleditor.css" file in main
> "style.css" file.
>
>
> Thanks to Chethana for his UI related inputs and to Surinder for helping
> me on html alignment issues.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2017-12-19 14:17:00 Re: [pgAdmin4][Patch]: Adding connection status in Query tool
Previous Message Dave Page 2017-12-19 12:20:36 Re: [pgAdmin4][Patch]: RM #2964 - [Desktop Runtime] pgAdmin4 crash if user download query as CVS