From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Joao Pedro De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [patch] upgrade slickgrid |
Date: | 2017-05-17 13:01:43 |
Message-ID: | CA+OCxowQ6r1MfqnNptyD+DeOv8oQNNU7Apa4rSTKvW9b3ZYUGQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Wed, May 17, 2017 at 1:59 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> On Mon, May 15, 2017 at 7:35 PM, Joao Pedro De Almeida Pereira <
> jdealmeidapereira(at)pivotal(dot)io> wrote:
>
>> Hello Hackers
>>
>> We upgraded SlickGrid to the latest version + 53ee34. We upgraded since
>> we are working on some changes to the query results functionality,
>> including improvements to column selection and shortcuts.
>>
>> This SlickGrid upgrade includes a PR we wrote that simplifies some of
>> these changes.
>>
>> Please note that we are not requesting this be included in the 1.5
>> release.
>>
>
> Have you confirmed that removing the changes we made to shorten the class
> names used for rows and cells doesn't affect the performance or memory
> utilisation of the grid?
>
Also... would this be an appropriate time to remove the embedded libraries
altogether, and move to npm/yarn installations of them?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-05-17 13:13:10 | pgAdmin 4 commit: Various FTS dictionary cleanups. Fixes #1126 |
Previous Message | Dave Page | 2017-05-17 12:59:50 | Re: [patch] upgrade slickgrid |