| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: SYNONYM issue if use all special characters as name |
| Date: | 2016-10-14 23:02:16 |
| Message-ID: | CA+OCxowOu2rWz7Vy9Q4Z8w3H_7ppm4vV=aFk=tbGT71vo+Bzzw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, patch applied.
On Friday, October 14, 2016, Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
wrote:
> Hi
>
> *Issue:*
> If synonym name contains special characters, the request url is be '404
> not found'.
> i.e. It doesn't hit at 'sql' method of synonym.
>
> *Solution:*
> If URL has an identifier containing slash character '/' into the URI, then
> set param type to path.
> like /<path: int>.
> Because if param name contains '/' in synonym name, it gets confused and
> wrong route is formed.
> Reference:- http://flask.pocoo.org/snippets/76/
>
> Please find attached patch and review.
>
> Thanks,
> Surinder Kumar
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2016-10-14 23:29:06 | Re: [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220 |
| Previous Message | Dave Page | 2016-10-14 23:02:01 | pgAdmin 4 commit: Handle reverse engineering of synonyms with / in the |