Re: pgAdmin III commit: Fix dropping of constraints

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: Timon <timosha(at)gmail(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin III commit: Fix dropping of constraints
Date: 2012-11-08 15:28:37
Message-ID: CA+OCxowOgTPR9hRZNOJ+oktpE9k-1SYOAXSLECyGZDkywn2WQw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - applied.

On Thu, Nov 8, 2012 at 11:03 AM, Akshay Joshi
<akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
> Hi Dave
>
> On Thu, Nov 8, 2012 at 1:16 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Akshay, can you look at this please?
>
>
> Attached is the patch to fix the issue.Can you please review it and if it
> looks OK then please commit it.
>>
>>
>> Thanks.
>>
>> On Thu, Nov 8, 2012 at 6:32 AM, Timon <timosha(at)gmail(dot)com> wrote:
>> > crash after index rename
>> >
>> > stacktrace
>> > Thread 1 (Thread 0x7ffff7faea00 (LWP 13198)):
>> > #0 0x0000000000576d51 in dlgIndex::GetSql() ()
>> > No symbol table info available.
>> > #1 0x0000000000590e56 in dlgProperty::OnOK(wxCommandEvent&) ()
>> > No symbol table info available.
>> > #2 0x0000003f0b8e6796 in ProcessEventIfMatches (event=...,
>> > handler=<optimized out>, entry=...) at src/common/event.cpp:1239
>> > No locals.
>> > #3 wxEvtHandler::ProcessEventIfMatches (entry=..., handler=<optimized
>> > out>,
>> > event=...) at src/common/event.cpp:1214
>> > No locals.
>> >
>> >
>> >
>> > 2012/11/1 Dave Page <dpage(at)pgadmin(dot)org>
>> >>
>> >> Fix dropping of constraints
>> >>
>> >> Branch
>> >> ------
>> >> master
>> >>
>> >> Details
>> >> -------
>> >>
>> >>
>> >> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=e92f6be2c2872e85049a54f4b06613f9dd242b3b
>> >> Author: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
>> >>
>> >> Modified Files
>> >> --------------
>> >> CHANGELOG | 1 +
>> >> pgadmin/schema/pgCheck.cpp | 2 +-
>> >> pgadmin/schema/pgDomain.cpp | 2 +-
>> >> pgadmin/schema/pgForeignKey.cpp | 2 +-
>> >> pgadmin/schema/pgIndex.cpp | 8 ++++----
>> >> 5 files changed, 8 insertions(+), 7 deletions(-)
>> >>
>> >>
>> >> --
>> >> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> >> To make changes to your subscription:
>> >> http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>> >
>> >
>> >
>> > --
>> > All bugs reserved
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
>
>
> --
> Akshay Joshi
> Senior Software Engineer
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
> Phone: +91 20-3058-9522
> Mobile: +91 976-788-8246
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2012-11-08 15:38:19 pgAdmin III commit: Prevent a crash when refreshing a node which has a
Previous Message Dave Page 2012-11-08 15:28:31 pgAdmin III commit: Fix dropping/renaming of indexes