| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
| Cc: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4] [Patch]: Language Module |
| Date: | 2016-02-12 16:34:18 |
| Message-ID: | CA+OCxowNGRLM+uPzOTMVBVpLbbRNQU+A8eDz668ioVMi0x4vCQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Fri, Feb 12, 2016 at 11:21 AM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> Hi,
>
> New language patch is working fine.
> Ashesh - Can you please review it ?
> If it looks good then can you please commit ?
>
> Thank you,
> Harshal
>
A few comments:
- We omitted CREATE LANGUAGE, as most are now extensions. Shouldn't we also
therefore omit DROP LANGUAGE?
- Please leave a blank line between the file header and python code in
python files.
- The pydoc module description is missing from __init__.py
- What about the Dependents and Dependencies tabs?
- There are few, if any comments in the Javascript. There should be at
least minimal comments there to note the purpose of each logical code block.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2016-02-12 16:40:32 | pgAdmin 4 commit: Don't add (GROUP) to the end of group role names; tha |
| Previous Message | Dave Page | 2016-02-12 16:24:50 | Re: patch for cast module |