Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires
Date: 2018-01-15 17:39:11
Message-ID: CA+OCxowN83A=8X8ixNWf9f7iC_PZn7vZvL1hOaFGAQos01kgUA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Mon, Jan 15, 2018 at 10:54 AM, Harshal Dhumal
<harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>
> Hi Dave,
>
> Please find rebased patch.
>
> Also I have made changes to existing code about showing connection status in query tool to make this work.

I ran the feature tests a couple of times, and in both cases got the
following error:

======================================================================
ERROR: runTest (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest)
Validate Insert, Update operations in View/Edit data with given test data
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
line 115, in runTest
self._verify_row_data(True)
File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
line 289, in _verify_row_data
self.page.find_by_id("btn-flash").click()
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 80, in click
self._execute(Command.CLICK_ELEMENT)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 501, in _execute
return self._parent.execute(command, params)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
line 308, in execute
self.error_handler.check_response(response)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py",
line 194, in check_response
raise exception_class(message, screen, stacktrace)
WebDriverException: Message: unknown error: Element <button
id="btn-flash" type="button" class="btn btn-default" style="width:
40px;" title="Execute/Refresh (F5)">...</button> is not clickable at
point (514, 20). Other element would receive the click: <div
class="ajs-modal" tabindex="0">...</div>
(Session info: chrome=63.0.3239.132)
(Driver info: chromedriver=2.35.528157
(4429ca2590d6988c0745c24c8858745aaaec01ef),platform=Mac OS X 10.12.6
x86_64)

I've attached a screenshot from the test run.

Thanks, Dave

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
CheckForViewDataTest-2018.01.15_23.04.28-Python-2.7.10.png image/png 306.2 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ioseph Kim 2018-01-16 01:23:42 Re: pgadmin4 server error message processing
Previous Message Dave Page 2018-01-15 17:09:42 Re: [pgAdmin4][Patch]: RM #2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret