From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4) |
Date: | 2016-08-09 12:58:18 |
Message-ID: | CA+OCxowMGSBwuAVj96y4eQ7FSFOnv943bkJZVzZ=SN8Rb3St3g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to fix the issue where message panel was showing incomplete info.
> We may still miss some messages from Psycopg2 driver due to limited size of
> notices queue.
> (RM#1523)
A few thoughts on this (mostly based on my discussions with Ashesh):
1) You seem to have removed the poll delay. I assume that is to try to
avoid missing messages? Can we re-introduce the delay (to avoid
excessive network requests), but collect messages while we're waiting?
2) If I run VACUUM, whilst I see messages as I should now, there is no
query time summary as there is for a query that returns data.
3) Can we incrementally display messages? e.g. each time we poll, we
add the new messages to the messages div, and scroll to the end
automatically?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2016-08-09 13:01:41 | Re: PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4) |
Previous Message | Albe Laurenz | 2016-08-09 12:39:40 | Re: pgAdmin 4 as Web application |