Re: Proposal for changes in official Docker image

Hi

On Fri, Mar 16, 2018 at 8:52 PM, Максим Кольцов <kolmax94(at)gmail(dot)com> wrote:
>
>
> I've switched to Gunicorn, adding SSL support. It has the same
> interface as the original container: PGADMIN_ENABLE_TLS,
> /certs/server.key and /certs/server.cert.
> I also incorporated building of sphinx manual in Dockerfile, so now
> the image should be complete.
>

Nice!

>
> I noticed that I can't use gunicorn forking worker with pgadmin4, this
> is probably caused by session implementation, but I'm not sure. You
> can investigate this by using e.g. `-w 4` in entrypoint.sh, otherwise
> it's working fine with single-process threaded worker.
>

This is expected, and the reason why is explained here:
https://www.pgadmin.org/docs/pgadmin4/2.x/server_deployment.html#requirements

>
> I will make my work into a patch and send it to the mail list soon.
> Meanwhile, it'd be great if you tested the updated image at
> https://hub.docker.com/r/maksbotan/pgadmin4/

I'll try to take a look later in the week (busy prepping for a release at
the moment).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company