Re: Build failed in Jenkins: pgadmin4-master-python26 #602

On Mon, Feb 12, 2018 at 6:30 AM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> On Fri, Feb 9, 2018 at 8:40 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi,
>>
>> Doesn't this need to include 2.7 in the test that'll install the newer
>> version of psycopg2? e.g.
>>
>> psycopg2>=2.7.3.2; python_version >= '2.7'
>>
> Sorry for the typo.
>
>
>> psycopg2==2.7.3.2; python_version < '2.7'
>>
>> Also, I think the change as written breaks the wheel generation (see the
>> comment at the top of requirements.txt). Changes are required
>> inpkg/pip/setup_pip.py aren't they?
>>
>>
> If we use the latest version of pip then we can also use psycopg2 binary
> package which will save us from compiling the
> psycopg2
> ​​
> source on client.
> http://initd.org/psycopg/docs/install.html#binary-install-from-pypi
>
> I have attached both patches,
> Please review
> ​ & check which one suites to our need., I've tested both patches and its
> working fine.
> ​
>

Thanks - I've committed the source fix for now, but... what do folks think
about using source in requirements.txt (for developers and official
packages, to ensure compiler compatibility etc), and the binary package in
the wheel?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company