Re: [pgAdmin4][Patch]: RM1581 - When switching between query tabs, the selected tab is not ready to run a query

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM1581 - When switching between query tabs, the selected tab is not ready to run a query
Date: 2016-09-07 15:20:56
Message-ID: CA+OCxow9_dhRCD9kmpyvwBRcRCpGTZprwrPR5AnnUbcuWDyjrQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - applied.

On Wed, Sep 7, 2016 at 3:27 PM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> Please find updated patch with below changes:
> 1. A code block is formatted, previously not aligned.
> 2. rebased the patch.
> 3. Remove trailing whitespace.
>
> On Wed, Sep 7, 2016 at 6:33 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> This doesn't apply - can you rebase it please?
>>
>> Thanks.
>>
>> On Wed, Sep 7, 2016 at 12:46 PM, Surinder Kumar
>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>> > Hi
>> >
>> > This patch contains following changes:
>> > 1) Set focus on query tool once loaded.
>> > 2) While switching b/w panels find active tab and set focus on query
>> > tool.
>> > 3) Remove whitespace from file.
>> >
>> > This will allow user to switch b/w panels without insisting user to
>> > click on
>> > query tool.
>> >
>> > Please find attached patch and review.
>> >
>> > Thanks,
>> > Surinder Kumar
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-09-08 06:18:26 Re: PATCH: Adding more confirmations in query tool (pgAdmin4)
Previous Message Dave Page 2016-09-07 15:20:50 pgAdmin 4 commit: Ensure the query tool editor has focus when the tab i