Re: [patch] Test dependencies and screenshots

Hi

On Thu, Mar 2, 2017 at 10:05 PM, Joao Pedro De Almeida Pereira
<jpereira(at)pivotal(dot)io> wrote:
> Hi,
> We adjusted the patches to correct the issues that you mentioned
>
> Improves screenshots and reduces test flakiness

Hmm, was that the 0.5 second sleep? I hate doing that, but sometimes
it's the only way that doesn't require far more effort than it's worth
:-(.

> - rename screenshot files to add python version
> - put screenshots into separate pg version folders

I tested on Python 2.7 and Python 3.5 on macOS 10.12;

- On both versions of Python I'm left with a running chromedriver
process after the tests have exited. Chrome itself exits though.

- Screenshots only appear to have been saved once (the first time I
ran on Python 2.7). No screenshots were saved for any of my subsequent
runs.

I induced test failure by modifying the connect to server test to wait
for a menu option of "Server...." instead of "Server...".

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company