From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Priyanka Shendge <priyanka(dot)shendge(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Kanchan Mohitey <kanchan(dot)mohitey(at)enterprisedb(dot)com> |
Subject: | Re: pgAdmin IV API test cases patch |
Date: | 2016-06-06 08:33:15 |
Message-ID: | CA+OCxow8Q83e7Tm+BC2bxq=oqwd-m4JS3y2KpzgFemc=wX=f=A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Sun, Jun 5, 2016 at 6:56 PM, Priyanka Shendge
<priyanka(dot)shendge(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch for API test cases for tree nodes/modules. This patch does not
> include
> api tests for following modules:
>
> 1. Type
> 2. Table child nodes
> 3. FTS modules
>
> Kindly, review the same and let me know for any modification.
I took a very quick look at the patch and immediately saw a serious
problem I'm afraid - you cannot hard-code paths like this:
+ if os.path.isfile('/home/edb/Downloads/pgadmin4/web/regression/'
+ 'parent_id.pkl'):
+ exst_server_id = open('/home/edb/Downloads/pgadmin4/web'
+ '/regression/''parent_id.pkl', 'rb')
You need to dynamically generate such paths so this will work on any
machine. Look at line 19 of web/pgAdmin4.py to see how to get the
patch to the current file as an example.
Also; despite this not being part of the end-user interface, please
try to follow the standards for messages, e.g. instead of:
No event trigger(s) to update!!!
use
No event trigger(s) to update.
There is likely more to change of course, but please fix these issues first.
Thanks!
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Priyanka Shendge | 2016-06-06 08:39:13 | Re: pgAdmin IV API test cases patch |
Previous Message | Dave Page | 2016-06-06 08:23:41 | Re: Patch for pgAdmin4 RPM package |