Re: [pgAdmin4][Patch]: RM 3702 - pgAdmin dashboard showing the oid for the user-defined tables and table names for the catalog tables in locks monitoring window

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM 3702 - pgAdmin dashboard showing the oid for the user-defined tables and table names for the catalog tables in locks monitoring window
Date: 2019-01-04 14:45:40
Message-ID: CA+OCxow7Rwu7YA45ZzE+XfX765iyuZP=+JwVHpqFsxJwmErnMg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Fri, Jan 4, 2019 at 11:53 AM Khushboo Vashi
<khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
> Hi,
>
> Please find the attached patch to fix RM #3702 - pgAdmin dashboard showing the oid for the user-defined tables and table names for the catalog tables in locks monitoring window.
>
> Dashboard > Server Activity > Locks - shows the table oid in the 'Target relation' column instead of table name.
>
> The attached patch fixes this issue for the database level but not for the server level. The reason for this is, at the server level we fetch the data from the pg_locks with the maintenance database, so it can not fetch the pg_class relation for the other database tables (relation::regclass).
>
> Please find the attached screen-shots for the issue and the fix and let me know if there is any other way to fix this.
>
> Thanks,
> Khushboo
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2019-01-04 14:51:28 Re: Japanese translation for v3.7
Previous Message Dave Page 2019-01-04 14:45:33 pgAdmin 4 commit: Ensure we display the relation name (and not the OID)